Codeception / Codeception/module-symfony
Backwards compatibility break in `RouterAssertionsTrait::seeCurrentRouteIs()`
- Lingua principale
- PHP
- Stelle
- 96
- Fork
- 25
- Merge medio
- 2h 35m
- PR unite (30g)
- 3
Descrizione
https://github.com/Codeception/module-symfony/pull/227 broke backwards compatibility with tests written for prior versions of the module.
The following test now fails:
```php
$I->seeCurrentRouteIs('some_route', [
'id' => 1,
]);
```
With:
```
- Expected | + Actual
@@ @@
Array &0 [
'_route' => 'some_route',
- 'id' => 1,
+ 'id' => '1',
]
```
This usage is even how the method is documented:
https://github.com/Codeception/module-symfony/blob/01cfa3e12917e396cf99cee1fb63a553865cad16/src/Codeception/Module/Symfony/RouterAssertionsTrait.php#L87
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Start in src/Codeception/Module/Symfony/RouterAssertionsTrait.php at seeCurrentRouteIs(), and compare the behavior introduced by pull request #227. Reproduce the documented call with an integer id, then add or update a regression test if the existing test suite has coverage for this assertion. Done means prior calls continue comparing integer route parameters without converting them to strings.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- php, symfony
- Ambito
- backend, testing
- Tipo di issue
- Bug
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 68/100