Codeception / Codeception/module-symfony
Backwards compatibility break in `RouterAssertionsTrait::seeCurrentRouteIs()`
- Lenguaje dominante
- PHP
- Estrellas
- 96
- Forks
- 25
- Merge medio
- 2 h 35 min
- PR fusionados (30 d)
- 3
Descripción
https://github.com/Codeception/module-symfony/pull/227 broke backwards compatibility with tests written for prior versions of the module.
The following test now fails:
```php
$I->seeCurrentRouteIs('some_route', [
'id' => 1,
]);
```
With:
```
- Expected | + Actual
@@ @@
Array &0 [
'_route' => 'some_route',
- 'id' => 1,
+ 'id' => '1',
]
```
This usage is even how the method is documented:
https://github.com/Codeception/module-symfony/blob/01cfa3e12917e396cf99cee1fb63a553865cad16/src/Codeception/Module/Symfony/RouterAssertionsTrait.php#L87
Guía de contribución
Línea de trabajo
Start in src/Codeception/Module/Symfony/RouterAssertionsTrait.php at seeCurrentRouteIs(), and compare the behavior introduced by pull request #227. Reproduce the documented call with an integer id, then add or update a regression test if the existing test suite has coverage for this assertion. Done means prior calls continue comparing integer route parameters without converting them to strings.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- php, symfony
- Área
- backend, testing
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 68/100