Codeception / Codeception/module-symfony
Backwards compatibility break in `RouterAssertionsTrait::seeCurrentRouteIs()`
Open
- Dominant language
- PHP
- Stars
- 96
- Forks
- 25
- Avg merge
- 2h 35m
- Merged PRs (30d)
- 3
Description
https://github.com/Codeception/module-symfony/pull/227 broke backwards compatibility with tests written for prior versions of the module.
The following test now fails:
```php
$I->seeCurrentRouteIs('some_route', [
'id' => 1,
]);
```
With:
```
- Expected | + Actual
@@ @@
Array &0 [
'_route' => 'some_route',
- 'id' => 1,
+ 'id' => '1',
]
```
This usage is even how the method is documented:
https://github.com/Codeception/module-symfony/blob/01cfa3e12917e396cf99cee1fb63a553865cad16/src/Codeception/Module/Symfony/RouterAssertionsTrait.php#L87
Contributor guide
Assessment
This issue has not been assessed yet.