Codeception / Codeception/module-db

Fix a confusion between 'cleanup' and 'skip_cleanup_if_failed' configuration params

未关闭
#67 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
PHP
星标
23
派生
31
PR 合并指标
30 天内没有已合并 PR

描述

#### Problem
Currently we have configuration params `cleanup` and `skip_cleanup_if_failed`.
Despite their names sound similar, they are responsible for completely different things: `cleanup` controls the database re-creation before each test, and `skip_cleanup_if_failed` controls whether records, added by `haveInDatabase()` should be erased after the test.
#### Suggested fix
It would be good to distinguish these two 'cleanups' in documentation and in the names of config params in next major versions.
For example, to rename `cleanup` to `repopulate` (since we have `populate` responsible for initial database creation).

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。