Codeception / Codeception/module-db

Fix a confusion between 'cleanup' and 'skip_cleanup_if_failed' configuration params

Aperta
#67 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
PHP
Stelle
23
Fork
31
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

#### Problem
Currently we have configuration params `cleanup` and `skip_cleanup_if_failed`.
Despite their names sound similar, they are responsible for completely different things: `cleanup` controls the database re-creation before each test, and `skip_cleanup_if_failed` controls whether records, added by `haveInDatabase()` should be erased after the test.
#### Suggested fix
It would be good to distinguish these two 'cleanups' in documentation and in the names of config params in next major versions.
For example, to rename `cleanup` to `repopulate` (since we have `populate` responsible for initial database creation).

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.