Codeception / Codeception/module-db

Fix a confusion between 'cleanup' and 'skip_cleanup_if_failed' configuration params

Open
#67 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
23
Forks
31
PR merge metrics
No merged PRs in 30d

Description

#### Problem
Currently we have configuration params `cleanup` and `skip_cleanup_if_failed`.
Despite their names sound similar, they are responsible for completely different things: `cleanup` controls the database re-creation before each test, and `skip_cleanup_if_failed` controls whether records, added by `haveInDatabase()` should be erased after the test.
#### Suggested fix
It would be good to distinguish these two 'cleanups' in documentation and in the names of config params in next major versions.
For example, to rename `cleanup` to `repopulate` (since we have `populate` responsible for initial database creation).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.