Codeception / Codeception/module-amqp

AMQP pushToQueue declares queue with default parameters

Abierto
#3 4 comentarios 4 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
PHP
Estrellas
4
Forks
9
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

https://github.com/Codeception/Codeception/blob/2.2.10/src/Codeception/Module/AMQP.php#L153

```php
$this->connection->channel()->queue_declare($queue);
```

If the queue is already declared it can cause error like this:
```
[PhpAmqpLib\Exception\AMQPProtocolChannelException] PRECONDITION_FAILED - inequivalent arg 'durable' for queue 'TEST.start' in vhost 'test_vhost': received 'false' but current is 'true'

Scenario Steps:

8. $I->pushToQueue("TEST.start","test") at tests/functional/startCest.php:53

```

I think that `queue_declare` call can be removed from `pushToQueue`, because separate `declareQueue` method was introduced in 2.2.9.
(Probably it is best to make this change in master branch)

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Start with src/Codeception/Module/AMQP.php around line 153 and compare pushToQueue with the separate declareQueue method introduced in 2.2.9. Review tests/functional/startCest.php around line 53 and verify that pushing to an already-declared queue no longer triggers an inequivalent durable-parameter error.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
php
Área
backend, testing-qa
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.