Codeception / Codeception/module-amqp

AMQP pushToQueue declares queue with default parameters

Open
#3 4 comments 4 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
4
Forks
9
PR merge metrics
No merged PRs in 30d

Description

https://github.com/Codeception/Codeception/blob/2.2.10/src/Codeception/Module/AMQP.php#L153

```php
$this->connection->channel()->queue_declare($queue);
```

If the queue is already declared it can cause error like this:
```
[PhpAmqpLib\Exception\AMQPProtocolChannelException] PRECONDITION_FAILED - inequivalent arg 'durable' for queue 'TEST.start' in vhost 'test_vhost': received 'false' but current is 'true'

Scenario Steps:

8. $I->pushToQueue("TEST.start","test") at tests/functional/startCest.php:53

```

I think that `queue_declare` call can be removed from `pushToQueue`, because separate `declareQueue` method was introduced in 2.2.9.
(Probably it is best to make this change in master branch)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/Codeception/Module/AMQP.php around line 153 and compare pushToQueue with the separate declareQueue method introduced in 2.2.9. Review tests/functional/startCest.php around line 53 and verify that pushing to an already-declared queue no longer triggers an inequivalent durable-parameter error.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.