CodeForPhilly / CodeForPhilly/codeforphilly.org

Create template for project cards on homepage

Đang mở
#46 8 bình luận 0 reaction 1 người được giao Được @tblacknc nhận Xem trên GitHub
Ngôn ngữ chính
CSS
Star
10
Fork
7
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Currently, we show cards for selected projects on the homepage (codeforphilly.org):

![image](https://user-images.githubusercontent.com/2574498/150041290-80f2cb11-d29e-446f-bf71-5e76df0ad465.png)

However, the HTML for each card is repeated, with information like heading hard-coded:

https://github.com/CodeForPhilly/codeforphilly.org/blob/develop/html-templates/home.tpl#L100-L115

## Proposed Solution

If we use a template, then we can consolidate this repeated code into one place. In other words, we could have a template like this in the `home.tpl` page:

```
{template projectTile name description logo=no}

{$name|escape}


{$description|escape|markdown}
{/template}
```

And then create the individual cards using something like this:

```
{projectTile name="Project 1" description="## This is a cool project"}
{projectTile name="Project 2" description="## This is a another project"}
```

Here is a link to the [template engine docs (owoo)](https://web.archive.org/web/20200223131043/http://dwoo.org/documentation/v1.3/dwoo-for-designers.html). Note that it is fairly old, but if we can get our work pretty far, and post it on the #cfp-homepage-redesign channel, we can hopefully lean a bit on @themightychris to fill in any gaps.

## Outcome

The homepage should look the exact same, but the underlying code should be much cleaner, since it uses the template. If there are any useful changes to the look / homepage content, let's handle them after implementing a template (just to be sure we get templating down).

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.