CodeEditApp / CodeEditApp/CodeEdit

✨ Add missing theme tokens

Đang mở
#1,925 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
enhancement theme
Ngôn ngữ chính
Swift
Star
23k
Fork
1.2k
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

### Description

We currently have "Types" and "Variables" theme tokens. We should replace these two with "Types Declarations", "Type Names", "Variable Declarations", "Variable Names". There are also several more that we might add...

- `classNames`
- `typeDeclarations`
- `typeNames`
- `variableDeclarations`
- `variableNames`
- `functionDeclarations`
- `functionNames`
- `propertyNames`
- `constants`
- `parameterNames`
- `moduleNames`
- `namespaceNames`
- `preprocessorMacros`
- `enumMembers`
- `annotations`

If we added these, the complete token list would look like this...

- `text`
- `background`
- `insertionPoint`
- `lineHighlight`
- `selection`
- `invisibles`
- `keywords`
- `classNames`
- `types`
- `typeDeclarations`
- `typeNames`
- `attributes`
- `commands`
- `values`
- `constants`
- `numbers`
- `strings`
- `characters`
- `variableDeclarations`
- `variableNames`
- `propertyNames`
- `parameterNames`
- `functionDeclarations`
- `functionNames`
- `moduleNames`
- `namespaceNames`
- `enumMembers`
- `preprocessorMacros`
- `annotations`
- `comments`

### Additional Context

In Xcode, class names, function names, type names, etc. are differentiated between “Project” and “Other”. This helps developers quickly see what’s part of their project vs. an external dependency, making it easier to navigate complex projects, identify ownership of code, and make refactoring decisions. Is this something we want to implement as well?

We also need to update all of our bundled themes to include these tokens.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.