CodeEditApp / CodeEditApp/CodeEdit

🐞 `cmd+delete` for deleting terminal become inactive after trying to delete a file with the shortcut

Đang mở
#1,343 0 bình luận 0 reaction 1 người được giao Được @Wouter01 nhận Xem trên GitHub
bug
Ngôn ngữ chính
Swift
Star
23k
Fork
1.2k
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

### Description

In PR #1329, some improvements on the focus system are added so commands like `cmd+delete` for deleting current terminal or selected file can be handled more easily. But, after the user selects a file and try to use `cmd+delete` to delete a file (which will not work because it's not implemented), `cmd+delete` for deleting the terminal will also stop working.

### To Reproduce

1. Open a project with CodeEdit
2. Select a terminal tab
3. Use `cmd+delete` to delete the terminal (it will work as intended)
4. Select a file
5. Use `cmd+delete` to delete the file (it will not work because it's yet to be implemented)
6. Select a terminal tab again
7. Use `cmd+delete` to delete the terminal (this time it will stop working)

### Expected Behavior

The terminal should be deleted.

### Version Information

CodeEdit: commit 6f3915990f317ce59fac58ae4a787bd9e4b0cc22
macOS: macOS Sonoma 14.0 Beta (23A5257q)
Xcode: 15.0 beta (15A5160n)

### Additional Context

_No response_

### Screenshots

https://github.com/CodeEditApp/CodeEdit/assets/72877496/f1d7b4f4-6012-4166-ac54-b6b24012fb6b

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.