ClickHouse / ClickHouse/clickhouse-java

[client-v2,jdbc-v2] Remove default socket snd/rcv buffer

Aperta
#3,121 1 commento 0 reazioni 1 assegnatario Rivendicata da @polyglotAI-bot Vedi su GitHub
Lingua principale
Java
Stelle
1.6k
Fork
636
Merge medio
2g 23h
PR unite (30g)
29

Descrizione

### Description

There are two parameters in `com.clickhouse.client.api.ClientConfigProperties`:
- `SOCKET_RCVBUF_OPT("socket_rcvbuf", Integer.class, "804800")`
- `SOCKET_SNDBUF_OPT("socket_sndbuf", Integer.class,"804800")`

They are setting TCP socket receive and send buffers. This is for any socket created by the client.
Values of this parameters should be calculated depending on network available throughput and very depend on environment. So modern system have auto configuration to reach performance. Besides this parameters are limited by OS. Setting them to specific values in application turn off auto-configuration.

We should remove this values and document that setting them is not recommended until user know what she is doing.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.