ClickHouse / ClickHouse/clickhouse-java

[client-v2,jdbc-v2] Remove default socket snd/rcv buffer

Ouverte
#3,121 1 commentaire 0 réactions 1 personne assignée Réclamée par @polyglotAI-bot Voir sur GitHub
Langage dominant
Java
Étoiles
1.6k
Forks
636
Merge moyen
2 j 23 h
PR mergées (30 j)
29

Description

### Description

There are two parameters in `com.clickhouse.client.api.ClientConfigProperties`:
- `SOCKET_RCVBUF_OPT("socket_rcvbuf", Integer.class, "804800")`
- `SOCKET_SNDBUF_OPT("socket_sndbuf", Integer.class,"804800")`

They are setting TCP socket receive and send buffers. This is for any socket created by the client.
Values of this parameters should be calculated depending on network available throughput and very depend on environment. So modern system have auto configuration to reach performance. Besides this parameters are limited by OS. Setting them to specific values in application turn off auto-configuration.

We should remove this values and document that setting them is not recommended until user know what she is doing.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.