ClickHouse / ClickHouse/clickhouse-java

[client-v2,jdbc-v2] Remove default socket snd/rcv buffer

Open
#3,121 1 comment 0 reactions 1 assignee Claimed by @polyglotAI-bot View on GitHub
Dominant language
Java
Stars
1.6k
Forks
636
Avg merge
2d 16h
Merged PRs (30d)
28

Description

### Description

There are two parameters in `com.clickhouse.client.api.ClientConfigProperties`:
- `SOCKET_RCVBUF_OPT("socket_rcvbuf", Integer.class, "804800")`
- `SOCKET_SNDBUF_OPT("socket_sndbuf", Integer.class,"804800")`

They are setting TCP socket receive and send buffers. This is for any socket created by the client.
Values of this parameters should be calculated depending on network available throughput and very depend on environment. So modern system have auto configuration to reach performance. Besides this parameters are limited by OS. Setting them to specific values in application turn off auto-configuration.

We should remove this values and document that setting them is not recommended until user know what she is doing.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.