ClickHouse / ClickHouse/clickhouse-cpp

API change: Column methods should throw exceptions consistently

Aperta
#243 1 commento 0 reazioni 1 assegnatario Rivendicata da @Enmk Vedi su GitHub
3.0
Lingua principale
C
Stelle
382
Fork
209
Merge medio
2g 19h
PR unite (30g)
14

Descrizione

There are multiple places throughout the library that are really relaxed about input values\types, like:
- overrides of `Column::Append(ColumnRef column)` that just do nothing if column is of not expected type
- overrides of `Column::Load` that return false if column failed to load, sometimes eating an exception that could point to the root cause.
- etc.

Fixes scheduled for next API-breaking release (3.0?):
- `Column::Append` overrides should throw an exception if the input column is of the wrong type.
- `Column::Load` should change return type to `void` and throw an exception on error.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.