ClickHouse / ClickHouse/clickhouse-cpp

API change: Column methods should throw exceptions consistently

Abierto
#243 1 comentario 0 reacciones 1 asignado Reclamado por @Enmk Ver en GitHub
3.0
Lenguaje dominante
C
Estrellas
382
Forks
209
Merge medio
2 d 19 h
PR fusionados (30 d)
14

Descripción

There are multiple places throughout the library that are really relaxed about input values\types, like:
- overrides of `Column::Append(ColumnRef column)` that just do nothing if column is of not expected type
- overrides of `Column::Load` that return false if column failed to load, sometimes eating an exception that could point to the root cause.
- etc.

Fixes scheduled for next API-breaking release (3.0?):
- `Column::Append` overrides should throw an exception if the input column is of the wrong type.
- `Column::Load` should change return type to `void` and throw an exception on error.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.