ClickHouse / ClickHouse/clickhouse-cpp

API change: Column methods should throw exceptions consistently

Open
#243 1 comment 0 reactions 1 assignee Claimed by @Enmk View on GitHub
3.0
Dominant language
C
Stars
382
Forks
209
Avg merge
3h 58m
Merged PRs (30d)
12

Description

There are multiple places throughout the library that are really relaxed about input values\types, like:
- overrides of `Column::Append(ColumnRef column)` that just do nothing if column is of not expected type
- overrides of `Column::Load` that return false if column failed to load, sometimes eating an exception that could point to the root cause.
- etc.

Fixes scheduled for next API-breaking release (3.0?):
- `Column::Append` overrides should throw an exception if the input column is of the wrong type.
- `Column::Load` should change return type to `void` and throw an exception on error.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.