CacheControl / CacheControl/json-rules-engine
Decreased Performance due to 'debug(...)' statements in production
- 主要言語
- JavaScript
- スター
- 3.1k
- フォーク
- 507
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
Hi @CacheControl
Hope your doing well 😄
First I'd like to thank you for the work done, this is a really useful package !
I'd like to point out a performance issue we are facing in production, there's a debug statement that is run while the addFact function is executed which cause a 2 seconds delay
```typescript
addFact (id, valueOrMethod, options) {
let factId = id
let fact
if (id instanceof Fact) {
factId = id.id
fact = id
} else {
fact = new Fact(id, valueOrMethod, options)
}
debug(`engine::addFact id:${factId}`) // <--- This one
this.facts.set(factId, fact)
return this
}
```
Here's our CPU Profiling
Is there a way to disable the debug statements ? Otherwise it could be nice to add an option to disable them
Thanks !
If you would like, I would be glad to open a PR to address the following issue.
Have a nice day 😄
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
評価
この issue はまだ評価されていません。