CDCgov / CDCgov/DynODE

Need to relook `config.dimension.VaccinationDimension`...

Open
#463 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
13
Forks
3
Avg merge
19h 43m
Merged PRs (30d)
1

Description

The VaccinationDimension currently has very specific use case: ordinal + 1 seasonal... but as it happens, we could have ordinal + 2 seasonal and this would not fit into this dimension's logic... (And it turns out that SMH wants that!)

On top of that, I'm also not sure what exactly that we are using the special dimension for and how it is better than just using a generic Dimension. This requires a bit of a deeper look...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating config.dimension.VaccinationDimension and its usages, then compare them with the generic Dimension implementation. Clarify the required ordinal-plus-two-seasonal behavior and why the specialized dimension exists; done means the project has an agreed design and corresponding behavior that covers the SMH use case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.