BlueBrain / BlueBrain/NeuroMorphoVis

Bug loading morphologies in release

Open
#192 5 comments 0 reactions 1 assignee Claimed by @marwan-abdellah View on GitHub
bug
Dominant language
Python
Stars
138
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Thank you for this amazing tool!

I tried to install both in Mac and CentOS Blender version 3.5 with the provided script, but it usually found issues with package versions in pip.
The only solution I got left was to use the release version. However, I noticed I was missing fragments of my SWCs.

After digging a bit in the code of the release, I found a bug in the function "update_section_parenting" in "2.80/scripts/addons/neuromorphovis/nmv/skeleton/ops/skeleton_construction_ops.py".

As it is in the released code, lines 58 and 66 compare the last and first indices of different sections and check if they are the same.
But the function should check whether the index and **parent** index of consecutive sections are the same.

Thus, modifying the mentioned lines to:
58:` if section.samples[-1].index == i_section.samples[0].parent_index:`
66:` if section.samples[0].parent_index == i_section.samples[-1].index:`
solves the issue.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.