BCStudentSoftwareDevTeam / BCStudentSoftwareDevTeam/urcpp

Maximum total budget for a proposal changes from year to year

Đang mở
#186 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
HTML
Star
0
Fork
0
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Faculty stipends (which is solved by PR #183) brings about another issue, which is there is a warning hard-coded into the end of the proposal form which notifies the user that their proposal is over a certain amount: https://github.com/BCStudentSoftwareDevTeam/urcpp/blob/development/api/templates/pages/budget.html#L133

This number should be dynamic, which means it needs to be programmable in the Set Parameters page.

However, the current number ($8300) was derived from a $5300 faculty stipend (now wrong) + $3000 max budget for everything else (which may also change in the future). Worse yet, this doesn't take into consideration the fact that two or more faculty could be on a proposal, which would make the budget: 5300 + 5300 + 3000.

So, this needs reworked so that faculty stipends are treated separately from the other budget calculations when this warning is displayed. In reality, it should only be a check on the $3000 budget for everything else, and a separate check on the stipend based on the number of faculty on the proposal.

Both the stipend and the "everything else budgets" should be set in the Set Parameters page so they can change each year.

You'll also want to check the impact of this on previous years (i.e., fix the production data so the value is in there).

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.