Azure / Azure/data-api-builder

Add validation to the mapping for each entity on bootstrap

オープン
#425 コメント 4 件 リアクション 0 件 担当者 1 名 @aaronburtle が担当を希望しています GitHub で見る
validation
主要言語
C#
スター
1.5k
フォーク
370
平均マージ
3日 22時間
マージ済み PR(30日)
9

説明

## Background
**Mappings** define what names we want to be externally usable in order to access underlying database object associated with a given entity.

Reminder, the entity mapping section is used as follows per https://learn.microsoft.com/en-us/azure/data-api-builder/reference-configuration#format-49

```json
"mappings": {
"" : "",
"" : "",
"" : ""
}
```

### Validation

- Don't allow multiple column names to map to the same exposed name
- Don't allow multiple exposed names to map to the same backing column.

### Examples

For example,
- Entity **Book** with fields `id`, `title`, and `author`

```tsql
SELECT id, title, author FROM dbo.book
```

| id | title | author |
|---|---|---|
| 1 | MyBook | Me! |
| 2 | MyMystery | You! |

Mappings
```json
mappings: {
"title" : "author"
}
```

We can no longer have a request like the following return the "expected" value of the author field (also unclear how the GraphQL Schema generator deals with this and what fields are actually present on the request:

```graphql
query bookQuery {
books {
id
title
author
}

The `author` is un-reachable because the unmapped backing column "author" is not mapped and is overridden by the mapping for "title" .

### Expectation
In this case we should return a warning to the user that they have conflicts in their mapping. Either during startup? or request time?

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。