Azure / Azure/data-api-builder

Update how nextLink value is retrieved

Open
#2,901 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.5k
Forks
370
Avg merge
3d 22h
Merged PRs (30d)
9

Description

Currently the nextLink/after value is retrieved by removing the brackets and saving the contents. However, it is done by assuming that the brackets are in the first and last positions of the string. We need to update it to ensure that we do not delete any relevant information in case the brackets are not there.

Solutions:
1) Using `IndexOf` and `LastIndexOf` functions to check if the brackets exist and use their positions to delete them with regex (Similar to the way that it is done now)
2) Using only regex to only use the information found inside the brackets if they exist.

This task is made in reference to the following comment:
https://github.com/Azure/data-api-builder/pull/2893#discussion_r2413840792

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the referenced pull request discussion and locating the code that retrieves the nextLink/after value. Confirm the current bracket handling, then verify that bracketed values are extracted while values without brackets retain all relevant information.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.