Azure / Azure/azure-relay-java

Mistakes in exception handling HybridConnectionListener

Aperta
#71 2 commenti 0 reazioni 2 assegnatari Rivendicata da @kalkeea Vedi su GitHub
Relay
Lingua principale
Java
Stelle
8
Fork
15
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

We noticed a race condition occurring after a network disruption, the HybridConnectionListener continues to loop and does not properly detect the error and commence a fresh reconnection cycle.

The reason seems to be in the wrong runtime exceptions being caught in HybridConnectionListener.java.

I also removed all unnecessary throws and replaced catch(Throwable) by more specific exception after having run the code agains our sonar setup.

I advised our Microsoft representative to run your code against a standard code checking tool such as Sonar to take this kind of mistakes out the code! See attached my version of HybridConnectionListener.java - which we updated after your dev commit of Feb 7 (== 0.3 release version).
[HybridConnectionListener.java.txt](https://github.com/Azure/azure-relay-java/files/4646532/HybridConnectionListener.java.txt)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.