Azure / Azure/azure-relay-java

Mistakes in exception handling HybridConnectionListener

Abierto
#71 2 comentarios 0 reacciones 2 asignados Reclamado por @kalkeea Ver en GitHub
Relay
Lenguaje dominante
Java
Estrellas
8
Forks
15
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

We noticed a race condition occurring after a network disruption, the HybridConnectionListener continues to loop and does not properly detect the error and commence a fresh reconnection cycle.

The reason seems to be in the wrong runtime exceptions being caught in HybridConnectionListener.java.

I also removed all unnecessary throws and replaced catch(Throwable) by more specific exception after having run the code agains our sonar setup.

I advised our Microsoft representative to run your code against a standard code checking tool such as Sonar to take this kind of mistakes out the code! See attached my version of HybridConnectionListener.java - which we updated after your dev commit of Feb 7 (== 0.3 release version).
[HybridConnectionListener.java.txt](https://github.com/Azure/azure-relay-java/files/4646532/HybridConnectionListener.java.txt)

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.