Azure-Samples / Azure-Samples/ms-identity-android-java

Readme instructions do not produce correct Signature Hash

Đang mở
#58 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
Java
Star
34
Fork
30
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

> Please provide us with the following information:
> ---------------------------------------------------------------

### This issue is for a: (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ x ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)
```

### Minimal steps to reproduce
> Our customers follow the directions in readme file to connect to their own tenant
-clone the repository
-build in Android studio
-create App Registration in Azure Portal
-create redirect Uri using the package name and Hash generated from the Azure Portal instructions
-create json config file and intent-filter based on the information generated in the Azure Portal

### Any log messages given by the failure
> This produces an Msal exception:
com.microsoft.identity.client.exception.MsalClientException: The redirect URI in the configuration file doesn't match with the one generated with package name and signature hash. Please verify the uri in the config file and your app registration in Azure portal.

### Expected/desired behavior
> Our customers should be able to get our fundamental sample working with their own tenant by following the directions in the readme and official documentation

### OS and Version?
> Any recent version of Android

### Versions
> 2.21

### Mention any other details that might be useful

*****************************************
Hi Team!

I am a Microsoft Support Engineer who supports Msal. Our customers are frustrated with this sample because it cannot successfully build the PublicClientApplication when the customers follow our readme and official documentation to use it with their own tenant.

The reason for this is that the sample contains its own keystore and points to this keystore in the build files. The official guidance on getting a debug Signature Hash will produce the default debug Hash for the customer's instance of Android Studio; however, this sample builds with its own Signature Hash. So by following our guidance, the customer is actually using the incorrect Signature Hash to generate a redirect Uri and intent filter.

This can be resolved by explicitly explaining how our customers can customize their keytool command specifically for this sample. (Basically the customer needs to change the path to point to the project's keystore).
Even just pointing out the fact that the sample uses its own keystore and the customer will need to adjust the keytool command will be a great improvement.

Step 5 in the portion in the readme about using your own App Registration might be a good place for this:
![image](https://user-images.githubusercontent.com/35708097/138791427-81f0d30d-cd97-4472-8663-ab43bb629b70.png)

*******************************************

> ---------------------------------------------------------------
> Thanks! We'll be in touch soon.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.