Azure-Samples / Azure-Samples/SQL-AI-samples
MssqlMcp: Incorrect tool tags - 'List Tables' marked as destructive, 'Create Table' marked as read-only
- Ngôn ngữ chính
- HTML
- Star
- 331
- Fork
- 208
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
## Problem
The MssqlMcp .NET server has incorrect tool tags that misrepresent the nature of operations:
**Current (incorrect) behavior:**
- `ListTables` is tagged as **destructive**
- `CreateTable` is tagged as **read-only**
- `DescribeTable` is tagged as **read-only** ✓ (correct)
**Expected behavior:**
- `ListTables` should be tagged as **read-only** (it only queries metadata via INFORMATION_SCHEMA or sys tables)
- `CreateTable` should be tagged as **destructive** or **write** (it modifies database schema)
- Other write operations (`InsertData`, `UpdateData`, `DropTable`) should also be reviewed for correct tagging
## Impact
This causes user confusion and may trigger unnecessary confirmations for safe read operations while failing to warn about actual schema modifications.
## Environment
- MssqlMcp version: Built from main branch (dotnet implementation)
- .NET 8.0
- MCP SDK: Official C# SDK
## Steps to Reproduce
1. Configure MssqlMcp server in Claude Desktop or VS Code
2. View available tools
3. Observe incorrect tags on `ListTables` (destructive) and `CreateTable` (read-only)
## Additional Context
The tool tags appear to be swapped or misconfigured in the tool definitions. `ListTables` performs a SELECT query on database metadata and should be completely safe/read-only.
Hướng dẫn đóng góp
Hướng nghiên cứu
Start by locating the MssqlMcp tool definitions for ListTables, CreateTable, DescribeTable, InsertData, UpdateData, and DropTable. Compare each tag with the operation it performs, then review the available tools in Claude Desktop or VS Code to confirm read operations do not appear destructive and schema-changing operations are appropriately marked.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- csharp, sql
- Lĩnh vực
- databases
- Loại issue
- Lỗi
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 38/100