Automattic / Automattic/VIP-Coding-Standards

Improve flush_rewrite_rules warning

未关闭
#701 1 条评论 4 个 reaction 已指派 0 人 在 GitHub 查看
Type: Enhancement
主要语言
PHP
星标
261
派生
44
平均合并
19 分钟
30 天内合并 PR
1

描述

## What problem would the enhancement address for VIP?

Right now here's the rule that we see when you try to use `flush_rewrite_rules()`:

> 🚫 Error( severity 5 ): flush_rewrite_rules should not be used in any normal circumstances in the theme code (WordPressVIPMinimum.Functions.RestrictedFunctions.flush_rewrite_rules_flush_rewrite_rules).

I feel like adding more context here as to "why" would be helpful, and also adding cases where this might be appropriate? For example, what about in a plugin activation/deactivation hook?

## Describe the solution you'd like

1. Why should you not use it
2. When it might be ok to use
3. What the effect of using it would have
4. Link to a doc on docs.wpvip.com to more details

贡献指南

打开贡献指南

调研方向

找到发出 flush_rewrite_rules 警告的 PHP_CodeSniffer 规则,并查看其现有消息和相关文档。更新警告,解释为什么不建议使用该函数、何时适合使用激活或停用钩子、它的影响,以及相关的 docs.wpvip.com 链接;如果存在该规则的测试,请进行验证。

由索引模型根据 Issue 内容生成。

评估

技术栈
php, wordpress
领域
documentation, tooling
Issue 类型
功能
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。