Automattic / Automattic/VIP-Coding-Standards

Review all sniffs for compatibility with PHPCS >= 4.0

未关闭
#552 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
PHPCSUtils
主要语言
PHP
星标
261
派生
44
平均合并
19 分钟
30 天内合并 PR
1

描述

Development on PHPCS 4.x has started a while back.

While there is no timeline known for when it will be ready/released, some (breaking) changes which PHPCS 4.x will contain are already known.

Notable changes as known at the time of writing this:
* The minimum supported PHP version is slated to become PHP 7.2.
* Support for the PEAR installation method will be removed.
* Support for JS and CSS sniffs will be removed.
* Support for the "old-style" ignore annotations, like `@codingStandardsIgnoreLine` will be removed. These were deprecated in PHPCS 3.2.0.
* Support for the "old-style" array properties in rulesets, where array items would be passed via a comma separated value instead of as individual items. This was deprecated in PHPCS 3.3.0.
* Deprecated tokens will be removed, most notably `T_ARRAY_HINT` and `T_RETURN_TYPE` which were both deprecated in PHPCS 3.3.0.

I expect most of this won't have much effect on the sniffs in VIPCS. If/when more changes become known, I will update the above list.

However, a decision is needed about the future of the sniffs which look at JS/CSS code. There is no urgency (yet), but I'm opening this issue now to raise awareness and open the discussion about this.

贡献指南

打开贡献指南

调研方向

未指定具体文件或测试。首先,根据列出的 PHPCS 4.x 更改检查所有 VIPCS sniff,然后查看关于移除还是保留 JavaScript 和 CSS sniff 的讨论。完成的标准是记录兼容性调查结果,并就受影响的 sniff 做出决定。

由索引模型根据 Issue 内容生成。

评估

技术栈
php
领域
devtools
Issue 类型
重构
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
28/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。