Automattic / Automattic/VIP-Coding-Standards

Review all sniffs for compatibility with PHPCS >= 4.0

Abierto
#552 5 comentarios 0 reacciones 0 asignados Ver en GitHub
PHPCSUtils
Lenguaje dominante
PHP
Estrellas
261
Forks
44
Merge medio
19 min
PR fusionados (30 d)
1

Descripción

Development on PHPCS 4.x has started a while back.

While there is no timeline known for when it will be ready/released, some (breaking) changes which PHPCS 4.x will contain are already known.

Notable changes as known at the time of writing this:
* The minimum supported PHP version is slated to become PHP 7.2.
* Support for the PEAR installation method will be removed.
* Support for JS and CSS sniffs will be removed.
* Support for the "old-style" ignore annotations, like `@codingStandardsIgnoreLine` will be removed. These were deprecated in PHPCS 3.2.0.
* Support for the "old-style" array properties in rulesets, where array items would be passed via a comma separated value instead of as individual items. This was deprecated in PHPCS 3.3.0.
* Deprecated tokens will be removed, most notably `T_ARRAY_HINT` and `T_RETURN_TYPE` which were both deprecated in PHPCS 3.3.0.

I expect most of this won't have much effect on the sniffs in VIPCS. If/when more changes become known, I will update the above list.

However, a decision is needed about the future of the sniffs which look at JS/CSS code. There is no urgency (yet), but I'm opening this issue now to raise awareness and open the discussion about this.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

No se han especificado archivos ni pruebas concretos. Empieza revisando todos los sniffs de VIPCS con respecto a los cambios indicados de PHPCS 4.x y, después, examina el debate sobre si se deben eliminar o conservar los sniffs de JavaScript y CSS. Se considerará terminado cuando se documenten los hallazgos de compatibilidad y se llegue a una decisión sobre los sniffs afectados.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
php
Área
devtools
Tipo de issue
Refactorización
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
28/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.