AppImage / AppImage/type2-runtime

Find a better way to detect the build environment architecture

オープン
#55 コメント 4 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
C
スター
73
フォーク
35
PR マージ指標
30日以内にマージされた PR はありません

説明

The architecture check introduced in https://github.com/AppImage/type2-runtime/pull/49 breaks the detection on OSes other than Alpine because of them using busybox. On Ubuntu 22.04, `file` returns the following:

```
> file -L /bin/bash
/bin/bash: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=7a6408ba82a2d86dd98f1f75ac8edcb695f6fd60, for GNU/Linux 3.2.0, stripped
```

The output does _not_ match `x86_64`, the string probed by the bash script. Edit: to clarify: the issue here is that it probes against the _loader_ path, not the architecture reported by `file`.

Please note that this is not an imminent problem since I need to use the Alpine containerized build environment anyway due to the very simplistic build scripts. However, the chosen solution is not portable in any way.

By the way, `x86-64` would be working on both systems. However, I'd rather use a dedicated tool like `uname`. Unfortunately, busybox's implementation doesn't support `-p` properly in containers, it returns `unknown` there.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。