AppImage / AppImage/AppImageKit

Improve architecture guessing

Aberta
#908 2 comentários 0 reações 0 responsáveis Ver no GitHub
enhancement high-priority
Linguagem predominante
Sem dados de linguagem
Estrelas
9.4k
Forks
588
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Right now, the "architecture guessing" is quite unreliable. The latest attempts to improve the situation worsened the situation even.

We should rework it entirely. My proposal is to keep looking for all executable files and `.so*` library files. We check whether they are ELF files, then parse their architecture out. @azubieta had prepared some code somewhere for this purpose.

In case there's multiple architectures in the list, instead of having to ask the user we could try a "majority" approach. For instance, if there's an absolute majority, we pick that (we could even use a 2/3 or 3/4 majority approach to make it even more reliable). If we cannot guess it that way, we can at least show the user "these are the ones we found, please pick one by doing XYZ".

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.