AppImage / AppImage/AppImageKit

Improve architecture guessing

Ouverte
#908 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement high-priority
Langage dominant
Aucune donnée de langage
Étoiles
9.4k
Forks
588
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Right now, the "architecture guessing" is quite unreliable. The latest attempts to improve the situation worsened the situation even.

We should rework it entirely. My proposal is to keep looking for all executable files and `.so*` library files. We check whether they are ELF files, then parse their architecture out. @azubieta had prepared some code somewhere for this purpose.

In case there's multiple architectures in the list, instead of having to ask the user we could try a "majority" approach. For instance, if there's an absolute majority, we pick that (we could even use a 2/3 or 3/4 majority approach to make it even more reliable). If we cannot guess it that way, we can at least show the user "these are the ones we found, please pick one by doing XYZ".

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.