AppFlowy-IO / AppFlowy-IO/AppFlowy

[Bug] Shortcuts shown in toolbar are not updated with custom keys

Aperta
#4,417 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
bug editor
Lingua principale
Dart
Stelle
76.6k
Fork
6k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### Bug Description

Shortcuts shown in the editor's toolbar are not updated with custom keys set in AppFlowy app.

### How to Reproduce

1. Open a document
2. Change the shortcut of some editor command (ex: "Toggle Bold" from `ctrl+b` to `ctrl+/`)
3. Select some text in the editor and hover over the button to see the shortcut is still the same (ex: hover over "B" and see `ctrl+b` instead of the new shortcut)

### Expected Behavior

Should show the custom shortcut below the tooltip.

### Operating System

Linux

### AppFlowy Version(s)

Built from source

### Screenshots

[Screencast from 18-01-2024 15:16:00.webm](https://github.com/AppFlowy-IO/AppFlowy/assets/16005946/790b6287-5144-4480-b4e6-3a1763190192)

### Additional Context

The shortcut combination is hard coded: https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/toolbar/desktop/items/format_toolbar_items.dart#L9C18-L9C18

It should be updated with the custom one.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.