AppFlowy-IO / AppFlowy-IO/AppFlowy

[Bug] Shortcuts shown in toolbar are not updated with custom keys

Ouverte
#4,417 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
bug editor
Langage dominant
Dart
Étoiles
76.6k
Forks
6k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### Bug Description

Shortcuts shown in the editor's toolbar are not updated with custom keys set in AppFlowy app.

### How to Reproduce

1. Open a document
2. Change the shortcut of some editor command (ex: "Toggle Bold" from `ctrl+b` to `ctrl+/`)
3. Select some text in the editor and hover over the button to see the shortcut is still the same (ex: hover over "B" and see `ctrl+b` instead of the new shortcut)

### Expected Behavior

Should show the custom shortcut below the tooltip.

### Operating System

Linux

### AppFlowy Version(s)

Built from source

### Screenshots

[Screencast from 18-01-2024 15:16:00.webm](https://github.com/AppFlowy-IO/AppFlowy/assets/16005946/790b6287-5144-4480-b4e6-3a1763190192)

### Additional Context

The shortcut combination is hard coded: https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/toolbar/desktop/items/format_toolbar_items.dart#L9C18-L9C18

It should be updated with the custom one.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.