AndersDJohnson / AndersDJohnson/htmlcompressor

HtmlCompressor.java depends on Rhino unnecessarily

未關閉
#77 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
auto-migrated Priority-Medium Type-Defect
主要語言
Java
星號
1
分支
0
PR 合併指標
30 天內沒有已合併 PR

描述

```
When running the following code:
String html = "

A String

";
HtmlCompressor compressor = new HtmlCompressor();
String compressedHtml = compressor.compress(html);

We get the following stacktrace:
Caused by: java.lang.ClassNotFoundException: org.mozilla.javascript.ErrorReporter
at org.codehaus.groovy.tools.RootLoader.findClass(RootLoader.java:156)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at org.codehaus.groovy.tools.RootLoader.loadClass(RootLoader.java:128)
at org.codehaus.groovy.grails.cli.support.GrailsRootLoader.loadClass(GrailsRootLoader.java:43)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)

This is due to the fact that HtmlCompressor.java is relying on Rhino.
The Java ClassLoader doesn't seem to complain if the portion of code is not
used, but Groovy does.

All the code related to Rhino on this class is actually dead code, so it could
be removed and solve our problem.
Right now, our workaround is to include a dependency to Rhino, which is a bit a
shame.

Please find attached the patch removing the dead code.
The tests are still passing after patching.
```

Original issue reported on code.google.com by `pablo.t...@gmail.com` on 18 Sep 2012 at 11:33

Attachments:
- [rhino_dead_code.patch](https://storage.googleapis.com/google-code-attachments/htmlcompressor/issue-77/comment-0/rhino_dead_code.patch)

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。