AndersDJohnson / AndersDJohnson/htmlcompressor

HtmlCompressor.java depends on Rhino unnecessarily

未关闭
#77 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
auto-migrated Priority-Medium Type-Defect
主要语言
Java
星标
1
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

```
When running the following code:
String html = "

A String

";
HtmlCompressor compressor = new HtmlCompressor();
String compressedHtml = compressor.compress(html);

We get the following stacktrace:
Caused by: java.lang.ClassNotFoundException: org.mozilla.javascript.ErrorReporter
at org.codehaus.groovy.tools.RootLoader.findClass(RootLoader.java:156)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at org.codehaus.groovy.tools.RootLoader.loadClass(RootLoader.java:128)
at org.codehaus.groovy.grails.cli.support.GrailsRootLoader.loadClass(GrailsRootLoader.java:43)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)

This is due to the fact that HtmlCompressor.java is relying on Rhino.
The Java ClassLoader doesn't seem to complain if the portion of code is not
used, but Groovy does.

All the code related to Rhino on this class is actually dead code, so it could
be removed and solve our problem.
Right now, our workaround is to include a dependency to Rhino, which is a bit a
shame.

Please find attached the patch removing the dead code.
The tests are still passing after patching.
```

Original issue reported on code.google.com by `pablo.t...@gmail.com` on 18 Sep 2012 at 11:33

Attachments:
- [rhino_dead_code.patch](https://storage.googleapis.com/google-code-attachments/htmlcompressor/issue-77/comment-0/rhino_dead_code.patch)

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。