AndersDJohnson / AndersDJohnson/htmlcompressor

HtmlCompressor.java depends on Rhino unnecessarily

Open
#77 0 comments 0 reactions 0 assignees View on GitHub
auto-migrated Priority-Medium Type-Defect
Dominant language
Java
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

```
When running the following code:
String html = "

A String

";
HtmlCompressor compressor = new HtmlCompressor();
String compressedHtml = compressor.compress(html);

We get the following stacktrace:
Caused by: java.lang.ClassNotFoundException: org.mozilla.javascript.ErrorReporter
at org.codehaus.groovy.tools.RootLoader.findClass(RootLoader.java:156)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at org.codehaus.groovy.tools.RootLoader.loadClass(RootLoader.java:128)
at org.codehaus.groovy.grails.cli.support.GrailsRootLoader.loadClass(GrailsRootLoader.java:43)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)

This is due to the fact that HtmlCompressor.java is relying on Rhino.
The Java ClassLoader doesn't seem to complain if the portion of code is not
used, but Groovy does.

All the code related to Rhino on this class is actually dead code, so it could
be removed and solve our problem.
Right now, our workaround is to include a dependency to Rhino, which is a bit a
shame.

Please find attached the patch removing the dead code.
The tests are still passing after patching.
```

Original issue reported on code.google.com by `pablo.t...@gmail.com` on 18 Sep 2012 at 11:33

Attachments:
- [rhino_dead_code.patch](https://storage.googleapis.com/google-code-attachments/htmlcompressor/issue-77/comment-0/rhino_dead_code.patch)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.