Andarist / Andarist/stylis-plugin-extra-scope

Discussion: ":root" pseudo-class

Aperta
#12 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
23
Fork
14
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hello,

I have been using this plugin for a while and ran into an ambiguity with chakra-ui. Chakra-ui by default, converts all shared variables in js to css variables in a global file. These variables are under the ":root" pseudo class.

The feature-request/discussion:

Should ":root" be excluded from the scope prepending or should it be replaced with the scope completely?

From a correctness standpoint, replacement makes sense to me, however, certain ponyfills other scripts limit their scope to the general ":root" case. Part of me in inclined to have a configuration option like: "scopeRootPseudoClass" that can be configured.

Once this discussion is confirmed, I can go ahead and submit the PR if this is deemed useful!

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.