Andarist / Andarist/stylis-plugin-extra-scope

Discussion: ":root" pseudo-class

Abierto
#12 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
23
Forks
14
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hello,

I have been using this plugin for a while and ran into an ambiguity with chakra-ui. Chakra-ui by default, converts all shared variables in js to css variables in a global file. These variables are under the ":root" pseudo class.

The feature-request/discussion:

Should ":root" be excluded from the scope prepending or should it be replaced with the scope completely?

From a correctness standpoint, replacement makes sense to me, however, certain ponyfills other scripts limit their scope to the general ":root" case. Part of me in inclined to have a configuration option like: "scopeRootPseudoClass" that can be configured.

Once this discussion is confirmed, I can go ahead and submit the PR if this is deemed useful!

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.