Andarist / Andarist/stylis-plugin-extra-scope

Discussion: ":root" pseudo-class

Open
#12 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
23
Forks
14
PR merge metrics
No merged PRs in 30d

Description

Hello,

I have been using this plugin for a while and ran into an ambiguity with chakra-ui. Chakra-ui by default, converts all shared variables in js to css variables in a global file. These variables are under the ":root" pseudo class.

The feature-request/discussion:

Should ":root" be excluded from the scope prepending or should it be replaced with the scope completely?

From a correctness standpoint, replacement makes sense to me, however, certain ponyfills other scripts limit their scope to the general ":root" case. Part of me in inclined to have a configuration option like: "scopeRootPseudoClass" that can be configured.

Once this discussion is confirmed, I can go ahead and submit the PR if this is deemed useful!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.