Anas198900 / Anas198900/waledzaad

Closes #2222e

Đang mở
#12 0 bình luận 1 reaction 1 người được giao Được @Anas198900 nhận Xem trên GitHub
bug documentation duplicate enhancement good first issue help wanted invalid question wontfix
Ngôn ngữ chính
Không có dữ liệu ngôn ngữ
Star
2
Fork
0
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Closes #2222

Currently, the semantics of RegistrationShutdown are confusing. Its only affect connections that are currently created and registered. This means connections in the process of being created, or connections created after registration shutdown are not taken into consideration. Additionally, this can cause a shutdown event before a connection is returned to a user, which makes using the API much more complicated then it should be.

This change does 3 things.
1. After it is called, it doesn't allow any more connections to be created on the registration.
2. Any connections opened but not started will not receive a conn shutdown event from the registration shutdown event until they are started. This way the user knows no events on the connection will be called unless they either start the conn or explicitly shut it down or close it themselves.
3. If an open connection is started after registration shutdown, it will immediately shut down with the error code given by registration shutdown.

Some tests are added as well to verify this behavior. More are needed, but this is a start.

__Originally posted by @thhous-msft in https://github.com/microsoft/msquic/pull/2226__

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.