AltraMayor / AltraMayor/gatekeeper

struct flow_entry should have a single state: GK_BPF

Aperta
#602 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
C
Stelle
1.6k
Fork
252
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The states of a flow entry are `enum { GK_REQUEST, GK_GRANTED, GK_DECLINED, GK_BPF }`.

The states `GK_GRANTED` and `GK_DECLINED` have long been implemented as BPF programs, so their removal should not affect anyone. The downside of no longer having a way to compare the performance between built-in programs (i.e., the states `GK_GRANTED` and `GK_DECLINED`) and BPF programs is okay since that dropping the code associated with these deprecated states translates into a cleanup of the code of GK blocks.

Moving the state `GK_REQUEST` into a BPF program requires an extension of the running environment of the BPF programs. For example, the request BPF will need a way to update the expiration of flow entries and a mechanism to send packets to SOL blocks. A positive side effect of having a request BPF is to lower the effort to explore new strategies to prioritize undecided flows.

This streamline of `struct flow_entry` would be a preparation to integrate with [future SmartNICs that support running BPF programs](https://github.com/AltraMayor/gatekeeper/issues/599#issuecomment-1238302884).

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.