AltraMayor / AltraMayor/gatekeeper

struct flow_entry should have a single state: GK_BPF

Abierto
#602 2 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
C
Estrellas
1.6k
Forks
252
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

The states of a flow entry are `enum { GK_REQUEST, GK_GRANTED, GK_DECLINED, GK_BPF }`.

The states `GK_GRANTED` and `GK_DECLINED` have long been implemented as BPF programs, so their removal should not affect anyone. The downside of no longer having a way to compare the performance between built-in programs (i.e., the states `GK_GRANTED` and `GK_DECLINED`) and BPF programs is okay since that dropping the code associated with these deprecated states translates into a cleanup of the code of GK blocks.

Moving the state `GK_REQUEST` into a BPF program requires an extension of the running environment of the BPF programs. For example, the request BPF will need a way to update the expiration of flow entries and a mechanism to send packets to SOL blocks. A positive side effect of having a request BPF is to lower the effort to explore new strategies to prioritize undecided flows.

This streamline of `struct flow_entry` would be a preparation to integrate with [future SmartNICs that support running BPF programs](https://github.com/AltraMayor/gatekeeper/issues/599#issuecomment-1238302884).

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.