AltraMayor / AltraMayor/gatekeeper

struct flow_entry should have a single state: GK_BPF

Open
#602 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C
Stars
1.6k
Forks
252
PR merge metrics
No merged PRs in 30d

Description

The states of a flow entry are `enum { GK_REQUEST, GK_GRANTED, GK_DECLINED, GK_BPF }`.

The states `GK_GRANTED` and `GK_DECLINED` have long been implemented as BPF programs, so their removal should not affect anyone. The downside of no longer having a way to compare the performance between built-in programs (i.e., the states `GK_GRANTED` and `GK_DECLINED`) and BPF programs is okay since that dropping the code associated with these deprecated states translates into a cleanup of the code of GK blocks.

Moving the state `GK_REQUEST` into a BPF program requires an extension of the running environment of the BPF programs. For example, the request BPF will need a way to update the expiration of flow entries and a mechanism to send packets to SOL blocks. A positive side effect of having a request BPF is to lower the effort to explore new strategies to prioritize undecided flows.

This streamline of `struct flow_entry` would be a preparation to integrate with [future SmartNICs that support running BPF programs](https://github.com/AltraMayor/gatekeeper/issues/599#issuecomment-1238302884).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.