Altinity / Altinity/altinity-sql-browser

A queries-only bundle import no longer produces a Dashboard (favourite/membership decoupling in #427)

Abierto
#448 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

enhancement inbox
Lenguaje dominante
TypeScript
Estrellas
8
Forks
2
Merge medio
1 h 34 min
PR fusionados (30 d)
6

Descripción

Behaviour change from #427, flagged rather than folded in.

What changed

Before #427, importing a portable bundle that contained queries but no dashboards produced a Dashboard: addImportedFavoriteTiles(null, …) (src/workspace/import-planner.ts, removed in #427) minted the compatibility Dashboard from every spec.favorite === true panel query and gave each one a tile.

examples/iceberg-install.json is exactly that shape — 0 dashboards, 6 queries — so importing it used to hand the user a populated Dashboard.

#427 severed favourite from membership: a favourite is now a Library preference with no Dashboard meaning, so a queries-only import lands every query in the Library and creates no Dashboard at all. That is the correct end state (planImportQueries no longer touches any Dashboard, and every stored Dashboard comes through byte-identically), but it removes a route that existed.

Why it is deferred

The replacement route is #428: drag a Library query onto a Dashboard's Panels group, or use the keyboard-accessible Add to dashboard… equivalent, which creates an independent panel-role copy and a tile. Until #428 lands there is no in-app way to get a panel onto a Dashboard from a queries-only bundle — the user has to author the Dashboard by hand or import a bundle that carries one.

What to decide

  1. Is the #428 gap acceptable as an interim state, or does the import flow need an explicit "add these to a dashboard" step of its own?
  2. Should a queries-only import offer to create a Dashboard explicitly (a checkbox in the import dialog), now that it can no longer be inferred from a flag?
  3. examples/iceberg-install.json may want a Dashboard authored into it, so the shipped demo keeps working as documented in docs/ICEBERG-CATALOG-EXPLORER-DEMO.md.

Not folded into #427 because it is a product question about the import UX, and #427's own scope explicitly excludes assignment (that is #428's).

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza por src/workspace/import-planner.ts y los cambios de #427; después, revisa examples/iceberg-install.json y docs/ICEBERG-CATALOG-EXPLORER-DEMO.md. Revisa #428 como la ruta de reemplazo propuesta y determina si la importación debe crear u ofrecer una asignación de dashboard. Se considera terminado cuando la decisión de producto está tomada y el comportamiento de importación afectado y la documentación de la demo están alineados.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
frontend
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Tranquilo
Claridad
Necesita aclaración
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.