Altinity / Altinity/altinity-sql-browser
A queries-only bundle import no longer produces a Dashboard (favourite/membership decoupling in #427)
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 8
- Forks
- 2
- Ø Merge
- 1 Std. 34 Min.
- Gemergte PRs (30 T.)
- 6
Beschreibung
Behaviour change from #427, flagged rather than folded in.
What changed
Before #427, importing a portable bundle that contained queries but no dashboards produced a Dashboard: addImportedFavoriteTiles(null, …) (src/workspace/import-planner.ts, removed in #427) minted the compatibility Dashboard from every spec.favorite === true panel query and gave each one a tile.
examples/iceberg-install.json is exactly that shape — 0 dashboards, 6 queries — so importing it used to hand the user a populated Dashboard.
#427 severed favourite from membership: a favourite is now a Library preference with no Dashboard meaning, so a queries-only import lands every query in the Library and creates no Dashboard at all. That is the correct end state (planImportQueries no longer touches any Dashboard, and every stored Dashboard comes through byte-identically), but it removes a route that existed.
Why it is deferred
The replacement route is #428: drag a Library query onto a Dashboard's Panels group, or use the keyboard-accessible Add to dashboard… equivalent, which creates an independent panel-role copy and a tile. Until #428 lands there is no in-app way to get a panel onto a Dashboard from a queries-only bundle — the user has to author the Dashboard by hand or import a bundle that carries one.
What to decide
- Is the #428 gap acceptable as an interim state, or does the import flow need an explicit "add these to a dashboard" step of its own?
- Should a queries-only import offer to create a Dashboard explicitly (a checkbox in the import dialog), now that it can no longer be inferred from a flag?
examples/iceberg-install.jsonmay want a Dashboard authored into it, so the shipped demo keeps working as documented indocs/ICEBERG-CATALOG-EXPLORER-DEMO.md.
Not folded into #427 because it is a product question about the import UX, and #427's own scope explicitly excludes assignment (that is #428's).
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit src/workspace/import-planner.ts und den Änderungen aus #427 und sieh dir anschließend examples/iceberg-install.json sowie docs/ICEBERG-CATALOG-EXPLORER-DEMO.md an. Prüfe #428 als vorgeschlagene Ersatzroute und kläre, ob der Import eine Dashboard-Zuweisung erstellen oder anbieten soll. Erledigt ist die Aufgabe, wenn die Produktentscheidung feststeht und das betroffene Importverhalten sowie die Demo-Dokumentation darauf abgestimmt sind.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- typescript
- Bereich
- frontend
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Ruhig
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 35/100