AltimateAI / AltimateAI/altimate-code

data_diff: add dedicated unit test file for pure functions

Aperta
#718 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
811
Fork
134
Merge medio
3g 2h
PR unite (30g)
50

Descrizione

Flagged during v0.5.22 release review (Tech Lead persona).

The data_diff feature ships 1,164 lines in:
- `packages/opencode/src/altimate/native/connections/data-diff.ts`
- `packages/opencode/src/altimate/tools/data-diff.ts`

Coverage gap — no dedicated test file exercises the pure functions:
- `resolveTableSources`, `injectCte`
- `isAuditColumn`, `isAutoTimestampDefault`
- `buildColumnDiscoverySQL`, `parseColumnInfo`
- `quoteIdentForDialect`, `dateTruncExpr`
- `partitionMode`, `buildPartitionWhereClause`
- `mergeOutcomes`, `extractStats`

Create `packages/opencode/test/altimate/data-diff.test.ts` with table-driven tests per dialect (postgres, snowflake, bigquery, clickhouse, mysql, oracle, tsql). Estimated ~2 hours.

Deferred because: v0.5.22 ships adversarial tests covering the main attack surface via tool-facing paths. Dedicated unit coverage is a maintainability improvement, not a shipping blocker.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.