AltimateAI / AltimateAI/altimate-code

data_diff: add dedicated unit test file for pure functions

Abierto
#718 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
811
Forks
134
Merge medio
3 d 2 h
PR fusionados (30 d)
50

Descripción

Flagged during v0.5.22 release review (Tech Lead persona).

The data_diff feature ships 1,164 lines in:
- `packages/opencode/src/altimate/native/connections/data-diff.ts`
- `packages/opencode/src/altimate/tools/data-diff.ts`

Coverage gap — no dedicated test file exercises the pure functions:
- `resolveTableSources`, `injectCte`
- `isAuditColumn`, `isAutoTimestampDefault`
- `buildColumnDiscoverySQL`, `parseColumnInfo`
- `quoteIdentForDialect`, `dateTruncExpr`
- `partitionMode`, `buildPartitionWhereClause`
- `mergeOutcomes`, `extractStats`

Create `packages/opencode/test/altimate/data-diff.test.ts` with table-driven tests per dialect (postgres, snowflake, bigquery, clickhouse, mysql, oracle, tsql). Estimated ~2 hours.

Deferred because: v0.5.22 ships adversarial tests covering the main attack surface via tool-facing paths. Dedicated unit coverage is a maintainability improvement, not a shipping blocker.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.