AlphaWallet / AlphaWallet/alpha-wallet-android

Setup Danger to prevent Google Play services being included again

Aperta
#366 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement good first issue
Lingua principale
Java
Stelle
646
Fork
579
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Quote from @hboon

FYI. We have a Danger file at https://github.com/AlphaWallet/alpha-wallet-ios/blob/master/dangerfile.js that contains code to check for such things for iOS. It's just Javascript with convenient access to the code changes. So we have simple checks like if a string is added to the en localisation, we at least warn that other localisations should be added for other messages.

It can be configured so it's run automatically with Travis for PRs. We haven't done that yet, so I'm just running it as a post-commit hook locally:

#!/bin/sh
yarn run danger local

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.